Fixes #391 - trim wysiwyg:// from URL field if it's there.

[miketaylr]

Simple if matches regex, remove what was matched fix.

r? @magsout

[magsout]

To optimize this test, it might be interesting to add type=url? https://github.com/webcompat/webcompat.com/blob/master/webcompat/templates/form.html#L12 Instead of text ?

[miketaylr]

That's a good question. Originally I think the decision was to just stick with text because writing valid URLs by hand--especially on mobile--is a PITA. Maybe it's better to just be strict?

Let's get the feedback of @karlcow or @calexity.

[karlcow]

When do we receive ``wysiwyg://? in which circumstances? Is it the user typing it or is it created by the browser itself? With type=url` what are the things the user will not be able to do anymore?
What are the things this will allow the user to do?

Then after having answers to these questions we can decide. But that seems to be the call for an issue by itself ;)

[miketaylr]

When do we receive `wysiwyg://? in which circumstances?

See https://bugzilla.mozilla.org/show_bug.cgi?id=1098037 and a bunch of other bugs.

Is it the user typing it or is it created by the browser itself?

The browser, if a user is on a site like wired.com.

With type=url what are the things the user will not be able to do anymore?

Type "google.com". They'll be forced to type "http://google.com". More keystrokes with special characters on mobile keyboards is not fun.

What are the things this will allow the user to do?

No idea. :)

[miketaylr]

Type "google.com". They'll be forced to type "http://google.com"

Possibly fixed with @pattern attribute. But there's more problems: http://justmarkup.com/log/2012/12/28/input-url/

I think the simplest thing to do is not do strict url validation. Either way we decide (probably in another issue, maybe #306), removing wysiwyg://0/ as a workaround of a Gecko bug will need to happen.

[calexity]

I would prefer to not force anyone to put in a "valid" address given that you can put Google.com into your address bar and it works.

If you can strip out anything before the http, I think that's a better way to handle it. Is the issue that it's messy or hard to match multiple issues from the same domain?

[karlcow]

type='url'

• on iOS: triggers the character '/' and the choices of '.com' and so on.
• on Firefox OS: triggers the character '/'

On the other hand it indeed seems to require http:// Here I wonder if JS can specifically enhance the user experience by filling the http:// string so the user has only the rest to type. That's a good use of JS on the client side.

• The browser provides the user with customized keyboard
• The JS provides the fix for http://

[karlcow]

Also:

See the idea of Tiffany.

I put a test

[miketaylr]

I think these are all good thoughts, but orthogonal to the issue this PR addresses--which is to work around a Gecko bug. Let's continue the discussion in #404.

[karlcow]

Yes. Just need to see if @magsout is r+ or not. Thanks for opening the issue.

[magsout]

r+