Enable issues "pagination" dropdown. Fixes #372. #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| newUrl = this.issues.url.slice(0,-1) + this.issues.getNextPageNumber(); | ||
| this.issues.url = newUrl; | ||
| this.fetchAndRenderIssues(); | ||
| //TODO fix, this won't work. slice approach is bogus. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
r+ for the python bits. |
added 15 commits
November 24, 2014 10:32
We need to use the .copy() method because request.args is an ImmutableMultiDict. This allows us to modify/update.
…er than combined.
squash me with the updateIssues commit
This will likely change once Links are followed.
|
Just did a rebase to fix merge conflict in issue-list tests. |
|
OK, builds are passing. If there are no objections I'll probably merge this in a few hours so I can finish up #420. |
|
r+ @miketaylr |
magsout
added a commit
that referenced
this pull request
Nov 24, 2014
Enable issues "pagination" dropdown. Fixes #372.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the "issues per page" dropdown. Three choices, 25, 50 (default), 100 (max allowed by GitHub).
And add some functional tests that makes sure clicking opens it, clicking an option updates the label, and selecting a choice re-renders the view with the new amount.
r? @karlcow for the python bits
r? @magsout or @tagawa for JS (if either have time, I know it's a lot).
Thanks!