Fixes #479 - Better filter and sort integration for issues page. #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketaylr
force-pushed
the
issues/479/1
branch
from
4805ece to
70f25eb
Compare
|
Travis CI is failing Maybe due to interaction with live DB, we really need to stop testing live things. @miketaylr check for the test. |
|
Thanks for the review.
Nah, it failed because a previous PR included a test and a bugfix that this branch doesn't have yet: f92e75b. Just me forgetting to rebase. |
miketaylr
force-pushed
the
issues/479/1
branch
from
70f25eb to
eaf3911
Compare
|
Build is passing now, going to merge. |
miketaylr
pushed a commit
that referenced
this pull request
Dec 16, 2014
Fixes #479 - Better filter and sort integration for issues page.
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @karlcow