Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #507 - Scope toggleFilter to more specific class #520

Merged
merged 1 commit into from
Jan 2, 2015
Merged

Fix #507 - Scope toggleFilter to more specific class #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webcompat/static/js/lib/issue-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ issueList.DropdownView = Backbone.View.extend({
issueList.FilterView = Backbone.View.extend({
el: $('.js-issuelist-filter'),
events: {
'click button': 'toggleFilter'
'click .js-filter-button': 'toggleFilter'
},
_isLoggedIn: $('body').data('username'),
_userName: $('body').data('username'),
Expand Down
10 changes: 5 additions & 5 deletions webcompat/templates/issue-list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,19 @@
<script type="text/template" id="issuelist-filter-tmpl">
<div class="Dropdown Dropdown--large js-dropdown-wrapper"></div>
<div>
<button type="button" class="wc-Filter wc-Filter--untriaged" data-filter="untriaged">
<button type="button" class="wc-Filter wc-Filter--untriaged js-filter-button" data-filter="untriaged">
<span class="wc-Filter-count"></span> Untriaged</span>
</button>
<button type="button" class="wc-Filter wc-Filter--need" data-filter="needsdiagnosis">
<button type="button" class="wc-Filter wc-Filter--need js-filter-button" data-filter="needsdiagnosis">
<span class="wc-Filter-count"></span> Needs Diagnosis</span>
</button>
<button type="button" class="wc-Filter wc-Filter--ready" data-filter="contactready">
<button type="button" class="wc-Filter wc-Filter--ready js-filter-button" data-filter="contactready">
<span class="wc-Filter-count"></span> Ready for outreach</span>
</button>
<button type="button" class="wc-Filter wc-Filter--sitewait" data-filter="sitewait">
<button type="button" class="wc-Filter wc-Filter--sitewait js-filter-button" data-filter="sitewait">
<span class="wc-Filter-count"></span> Site contacted</span>
</button>
<button type="button" class="wc-Filter wc-Filter--close" data-filter="closed">
<button type="button" class="wc-Filter wc-Filter--close js-filter-button" data-filter="closed">
<span class="wc-Filter-count"></span> Closed</span>
</button>
</div>
Expand Down