Fix #604 - replace marked.js with markdown-it.js #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 6, 2015 16:08
|
OK, deployed to staging. |
|
Here's an issue you can test markdown out on: http://staging.webcompat.com/issues/241 |
| breaks: true, | ||
| html: true, | ||
| linkify: true | ||
| }).use(window.markdownitSanitizer); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
r + |
|
Faild here https://travis-ci.org/webcompat/webcompat.com/builds/57505689#L2838 But don't know why .. |
|
Hmm weird. |
|
I triggered a re-build, let's see how it goes. |
|
Green now, let's merge. 🎊 |
miketaylr
pushed a commit
that referenced
this pull request
Apr 7, 2015
Fix #604 - replace marked.js with markdown-it.js
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much nicer markdown library with plugin support. Once this is in place, we can add issue linking and pretty much anything else we want.
r? @magsout
PS, let me know if you want me to deploy this to staging to play around with it. My local tests look good--and it fixes the problem of not being able to display more than one emoji in a comment and other crappy marked.js bugs. We can do that after #564 lands.