Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #436 Add namespaces to labels #640

Merged
merged 2 commits into from
Jul 29, 2015
Merged

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Jun 25, 2015

This PR requires to change the labels on Github itself for the repo.
r? @miketaylr

@miketaylr
Copy link
Member

This PR requires to change the labels on Github itself for the repo.

I'll add the new labels to my test repo and run tests manually to verify that things are working.

@miketaylr
Copy link
Member

OK, next up on my plate. Sorry for taking so long on this. 🐢

@miketaylr
Copy link
Member

Testing this locally, everything seems to work, and tests pass. ☑️

@miketaylr
Copy link
Member

In order to not screw this up, I need to rename the labels in GitHub and deploy this at roughly the same time. But we need to update the bot first: miketaylr/web-bugs-issue-tagger#6

But let's go ahead and merge now.

miketaylr pushed a commit that referenced this pull request Jul 29, 2015
fix #436 Add namespaces to labels
@miketaylr miketaylr merged commit 1d1deea into webcompat:master Jul 29, 2015
@miketaylr
Copy link
Member

Oops, ran into one small issue with jshint. @karlcow, in the future when writing JS be sure to run grunt and it will lint the code for you. ❤️

(not a big issue)

@miketaylr
Copy link
Member

OK, all deployed. Seems to be working, based on webcompat/web-bugs#1487.

@karlcow karlcow deleted the 436/2 branch August 14, 2015 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants