Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #571. Change Browse Issues -> Latest Bugs #692

Merged
merged 9 commits into from
Sep 3, 2015
Merged

Conversation

miketaylr
Copy link
Member

Mostly removes a ton of code. I'm using the same markup patterns from issue-list.html, so the few issues we do show on the homepage will be "larger". But I think that's what the design from #571 shows (and it looks fine to me).

r? @magsout

@miketaylr
Copy link
Member Author

16/53 tests failed. That's weird.

return this.remote
.setFindTimeout(intern.config.wc.pageLoadTimeout)
.get(require.toUrl(url))
.findByCssSelector('.js-login-link').click()

This comment was marked as abuse.

@miketaylr
Copy link
Member Author

2/53 tests failed that's better! 🐋

@magsout
Copy link
Member

magsout commented Sep 2, 2015

LGTM. Good job @miketaylr 👍

@magsout
Copy link
Member

magsout commented Sep 2, 2015

Maybe last 10 bugs ?

@miketaylr
Copy link
Member Author

Maybe last 10 bugs ?

Yeah, agreed. Will change (and fix remaining failing tests).

@miketaylr miketaylr force-pushed the issues/571/1 branch 2 times, most recently from 8ff502b to 9da6ca2 Compare September 3, 2015 16:08
@miketaylr
Copy link
Member Author

OK, build # 814 passed. Good enough for me. :P

miketaylr pushed a commit that referenced this pull request Sep 3, 2015
Issue #571. Change Browse Issues -> Latest Bugs
@miketaylr miketaylr merged commit 84cd3fe into master Sep 3, 2015
@miketaylr miketaylr deleted the issues/571/1 branch September 3, 2015 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants