-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #571. Change Browse Issues -> Latest Bugs #692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
return this.remote | ||
.setFindTimeout(intern.config.wc.pageLoadTimeout) | ||
.get(require.toUrl(url)) | ||
.findByCssSelector('.js-login-link').click() |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
LGTM. Good job @miketaylr 👍 |
Maybe last 10 bugs ? |
Yeah, agreed. Will change (and fix remaining failing tests). |
…ove dead CSS code.
…ues" section of homepage.
miketaylr
force-pushed
the
issues/571/1
branch
from
September 3, 2015 15:21
afa0a7f
to
9a39731
Compare
miketaylr
force-pushed
the
issues/571/1
branch
2 times, most recently
from
September 3, 2015 16:08
8ff502b
to
9da6ca2
Compare
miketaylr
force-pushed
the
issues/571/1
branch
from
September 3, 2015 16:14
9da6ca2
to
accf310
Compare
OK, build # 814 passed. Good enough for me. :P |
miketaylr
pushed a commit
that referenced
this pull request
Sep 3, 2015
Issue #571. Change Browse Issues -> Latest Bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly removes a ton of code. I'm using the same markup patterns from issue-list.html, so the few issues we do show on the homepage will be "larger". But I think that's what the design from #571 shows (and it looks fine to me).
r? @magsout