Fixes #827. Refactor how we request data from GitHub. #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops @ |
added 4 commits
November 10, 2015 18:04
Part of this means we're always sending request headers to GitHub and always returning response headers from GitHub. Before it was only in some places. This might break things, or it might make them better!
miketaylr
force-pushed
the
endpoints-refactor
branch
from
ea5a0a6 to
e655005
Compare
| issues.status_code, get_headers(issues)) | ||
| # issues is a tuple of format: (content, status_code, response_headers) | ||
| if issues[1] == 200: | ||
| return (filter_new(json.loads(issues[0])), issues[1], issues[2]) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
added 2 commits
November 12, 2015 18:24
Also, update some of the comments in api_request helper method.
This already happens in api_request.
|
OK, I think I addressed your comments here @karlcow -- care to take a peek? |
| 'content': filter_new(json.loads(issues[0])), | ||
| 'status_code': issues[1], | ||
| 'response_headers': issues[2] | ||
| } |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
ok. :) Let's move forward. It will help us to have a clearer code. Thanks a lot mike. |
karlcow
added a commit
that referenced
this pull request
Nov 13, 2015
Fixes #827. Refactor how we request data from GitHub.
|
Thanks @karlcow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should pass all tests (at least it does locally!)
I'm going to do more manual testing and inspection of requests/responses, but it should be ready for review.
r? @karlcow