Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #915 - fixed position and z-index FormUpload #918

Merged
merged 1 commit into from
Feb 9, 2016

Conversation

magsout
Copy link
Member

@magsout magsout commented Feb 8, 2016

Close #915
r? @karlcow

I guess it was a z-index issue.

@miketaylr
Copy link
Member

Hmm, how strange. If I click anywhere except for the "Attach a Screenshot image" text -- it works.

BUT if I change the inner <label> (without the for='') to a <p> it works. Possible Firefox bug? Or is there something magical about nested label elements that I don't know about?

@miketaylr
Copy link
Member

Another issue, possibly related to the fix from https://github.com/webcompat/webcompat.com/pull/916/files is that now really big images are really big: https://cloudup.com/iVED0Y-qpZP

(If you're hooked up to the webcompat-tests repo, see Issue 321)

@magsout
Copy link
Member Author

magsout commented Feb 8, 2016

@miketaylr you tried with my PR ?

@magsout
Copy link
Member Author

magsout commented Feb 8, 2016

@miketaylr

Another issue, possibly related to the fix from https://github.com/webcompat/webcompat.com/pull/916/files is that now really big images are really big: https://cloudup.com/iVED0Y-qpZP

ARGggggggg

@miketaylr
Copy link
Member

@miketaylr you tried with my PR ?

@magsout yeah, I pulled down this branch.

@magsout
Copy link
Member Author

magsout commented Feb 8, 2016

jou739

@miketaylr
Copy link
Member

hehehe

@magsout
Copy link
Member Author

magsout commented Feb 8, 2016

@miketaylr

it works for me http://cl.ly/2Z3O2B2t3p2J

@magsout
Copy link
Member Author

magsout commented Feb 8, 2016

Another issue, possibly related to the fix from https://github.com/webcompat/webcompat.com/pull/916/files is that now really big images are really big: https://cloudup.com/iVED0Y-qpZP

@miketaylr fixed by #917

@karlcow
Copy link
Member

karlcow commented Feb 9, 2016

→ git checkout -b deleteme upstream/url-link-upload
Branch deleteme set up to track remote branch url-link-upload from upstream.
Switched to a new branch 'deleteme'
(webcompatcom)16:14:24 ~/code/webcompat.com
→ python run.py
secrets /Users/karl/code/webcompat.com
 * Running on http://localhost:5000/ (Press CTRL+C to quit)
 * Restarting with stat
secrets /Users/karl/code/webcompat.com

So the uploading form for bug reporting is working r+ for this one.

I could not test the login for comment because the callback is broken on my local build right now on a clean profile.

karlcow added a commit that referenced this pull request Feb 9, 2016
fix #915 - fixed position and z-index FormUpload
@karlcow karlcow merged commit 34772fb into master Feb 9, 2016
@karlcow
Copy link
Member

karlcow commented Feb 9, 2016

Thanks a lot @magsout

@miketaylr
Copy link
Member

I could not test the login for comment because the callback is broken on my local build right now on a clean profile.

Hmm, that's not good. A few random things to try:

  1. delete the local session database, restart the app
  2. from your github settings, revoke the app permission and do the auth dance again: https://github.com/settings/applications

@karlcow
Copy link
Member

karlcow commented Feb 9, 2016

@miketaylr that was my bad. ^_^ sorry about the noise.

@miketaylr
Copy link
Member

Ah, cool. Glad it's working. 🍥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants