Fix #929 - Make Error management more DRY #958

deepthivenkat · 2016-03-10T14:34:09Z

No description provided.

… error codes 400,401,403,404,500

webcompat/views.py

+              429: 'Cool your jets! Please wait {0} seconds before making'
+                   'another search.',
+              500: 'Internal Server Error',
+              GitHubError: 'Something bad happened. Please try again?'}


karlcow · 2016-03-11T08:23:09Z

@deepthivenkat

Oh and why the additional pull request here? You already started #949 which was not finished.

deepthivenkat · 2016-03-11T08:35:42Z

I would like to continue with this pull request as I have deleted the repository of the pull request #949

deepthivenkat · 2016-03-11T14:24:19Z

@karlcow when I read the code, I realized that GithubError is a class that is getting imported from flask.ext.github.

I also read from this link http://stackoverflow.com/questions/7560172/class-as-dictionary-key-in-python that class can be used as a key for Dictionary.

I also executed this code snippet in python interpreter before submitting the pull request :

class MyError(Exception):
        def dee_excep_():
            try:
                raise MyError(2*2)
            except MyError as e:
                return e.value
            dee_excep_()



ERROR_DICT = { 400: 'Bad Request.', 
               401: 'Unauthorized. Please log in.',
               403: 'Forbidden. Maybe that looking at private stuff?', 
           404: 'Not Found. Lost in Punk Cat Space',
               429: 'Cool your jets! Please wait {0} seconds before making'
               ' another search.',
               500: 'Internal Server Error',
               MyError: "'Something bad happened. Please try again?', 'error'"}

print ERROR_DICT[MyError]
print type(ERROR_DICT[MyError])

This executed without any errors. I did make built which did not return any errors. If this is causing the build to fail, I will change the dictionary key from class object to string.

… error codes 400,401,403,404,500

karlcow · 2016-03-14T02:11:22Z

So currently https://travis-ci.org/webcompat/webcompat.com/builds/115635958#L573
all the unit tests about errors are failing. We need to understand why.

karlcow · 2016-03-14T02:12:31Z

@deepthivenkat You need to run nosetests in your own directory and you will see the error messages.

…y that caused the tests to fail

tests/test_urls.py

@@ -61,11 +61,6 @@ def test_activity_page_401_if_not_logged_in(self):
        rv = self.app.get('/me')
        self.assertEqual(rv.status_code, 401)

-    def test_activity_page_403_view_other_user_activity(self):


…dy handled

webcompat/views.py

@@ -44,8 +43,7 @@
              404: 'Not Found. Lost in Punk Cat Space',
              429: 'Cool your jets! Please wait {0} seconds before making'
                   'another search.',


…code 429

karlcow · 2016-04-14T07:44:31Z

ok let's see

→ git pull https://github.com/deepthivenkat/webcompat.com.git Issue#929
remote: Counting objects: 8, done.
remote: Compressing objects: 100% (8/8), done.
remote: Total 8 (delta 3), reused 0 (delta 0), pack-reused 0
Unpacking objects: 100% (8/8), done.
From https://github.com/deepthivenkat/webcompat.com
 * branch            Issue#929  -> FETCH_HEAD
Merge made by the 'recursive' strategy.
 tests/test_urls.py |   1 +
 webcompat/views.py | 119 +++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------
 2 files changed, 38 insertions(+), 82 deletions(-)


(webcompatcom)16:40:13 ~/code/webcompat.com
→ git status
On branch deepthivenkat-Issue#929
nothing to commit, working directory clean


(webcompatcom)16:40:21 ~/code/webcompat.com
→ python run.py 
secrets /Users/karl/code/webcompat.com
 * Running on http://localhost:5000/ (Press CTRL+C to quit)
 * Restarting with stat
secrets /Users/karl/code/webcompat.com
127.0.0.1 - - [14/Apr/2016 16:41:07] "GET /api/jhkjhfkk HTTP/1.1" 404 -

then

→ http GET http://localhost:5000/api/jhkjhfkk 'Accept:application/json'
HTTP/1.0 404 NOT FOUND
Content-Length: 70
Content-Type: application/json
Date: Thu, 14 Apr 2016 07:41:26 GMT
Server: Werkzeug/0.10.4 Python/2.7.10

{
    "message": "Not Found. Lost in Punk Cat Space", 
    "status": 404
}

Good! r+
Thanks a lot @deepthivenkat 🎉

karlcow · 2016-04-14T07:46:41Z

Ahaha. One small thing to fix.
webcompat/views.py:297:1: E302 expected 2 blank lines, found 1

karlcow · 2016-04-15T04:20:40Z

So when I run the tests locally I have no issues.

→ nosetests
........................................
----------------------------------------------------------------------
Ran 40 tests in 4.773s

OK

but travis seems to have issues. Let's see
https://travis-ci.org/webcompat/webcompat.com/builds/122993115

ERROR: Test that we are receiving the appropriate text file.
FAIL: API issue for a non existent number returns JSON 404.
FAIL: API access to labels without auth returns JSON 200.

So there is something to explore here and understands why it doesn't fail locally but fails on travis.

For example

======================================================================

ERROR: Test that we are receiving the appropriate text file.

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/webcompat/webcompat.com/tests/test_urls.py", line 128, in test_rate_limit

    rv = self.app.get('/rate_limit')



(… CUTTING STUFF…)

  File "/home/travis/build/webcompat/webcompat.com/webcompat/views.py", line 253, in show_rate_limit

    return (render_template('ratelimit.txt', rl=rl), 200,

  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/flask/templating.py", line 128, in render_template

    context, ctx.app)

  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/flask/templating.py", line 110, in _render

    rv = template.render(context)

  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/jinja2/environment.py", line 989, in render

    return self.environment.handle_exception(exc_info, True)

  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/jinja2/environment.py", line 754, in handle_exception

    reraise(exc_type, exc_value, tb)

  File "/home/travis/build/webcompat/webcompat.com/webcompat/templates/ratelimit.txt", line 3, in top-level template code

    Core resources rate limit: {{ rl.resources.core.remaining }} / {{ rl.resources.core.limit }} requests.

  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/jinja2/environment.py", line 408, in getattr

    return getattr(obj, attribute)

UndefinedError: 'dict object' has no attribute 'resources'

-------------------- >> begin captured logging << --------------------

requests.packages.urllib3.connectionpool: INFO: Starting new HTTPS connection (1): api.github.com

requests.packages.urllib3.connectionpool: DEBUG: "GET /rate_limit HTTP/1.1" 401 83

--------------------- >> end captured logging << ---------------------

but if I do:

→ http GET http://localhost:5000/rate_limit 'Accept:application/json'

I get the right thing

HTTP/1.0 200 OK
Content-Length: 155
Date: Fri, 15 Apr 2016 04:17:09 GMT
Server: Werkzeug/0.10.4 Python/2.7.10
content-type: text/plain

Current user: webcompat-bot

Core resources rate limit: 4998 / 5000 requests.
Reset in 48 minutes.

Search rate limit: 30 / 30 requests.
Reset in 1 minute.

hmmm let's see. Maybe just a Travis thing.

miketaylr · 2016-04-19T18:17:20Z

Maybe just a Travis thing.

Yeah, it's a Travis thing. It runs into rate limiting probably because it has a shared Travis IP (this is only for tests that make unauthed APy I calls, from a PR from someone who doesn't have access to the secrets. Basically anyone not sending a PR from the webcompat repo itself). On my backlog of things to fix. 🙈

miketaylr · 2016-04-19T18:18:01Z

Great work @deepthivenkat!

deepthivenkat added 2 commits March 10, 2016 15:09

Issue webcompat#929 - Error Dictionary and generic error handlers for…

ea0deca

… error codes 400,401,403,404,500

Issue webcompat#929 - Error Dictionary and generic error handlers for…

8620cb1

… error codes 400,401,403,404,500

deepthivenkat mentioned this pull request Mar 10, 2016

Make error handler code in views.py more DRY #929

Closed

karlcow reviewed Mar 10, 2016
View reviewed changes

webcompat/views.py

429: 'Cool your jets! Please wait {0} seconds before making'

'another search.',

500: 'Internal Server Error',

GitHubError: 'Something bad happened. Please try again?'}

This comment was marked as abuse.

Sign in to view

karlcow mentioned this pull request Mar 11, 2016

Issue #929 - Generic error handler based on status code for status 40… #949

Closed

Issue webcompat#929 - Error Dictionary and generic error handlers for…

c844bed

… error codes 400,401,403,404,500

karlcow changed the title ~~Issue#929~~ Fix #929 - Make Error management more DRY Mar 14, 2016

Issue webcompat#929 - Removed the wrong status code passed in views.p…

cab3a29

…y that caused the tests to fail

miketaylr reviewed Mar 23, 2016
View reviewed changes

miketaylr mentioned this pull request Apr 5, 2016

Handle 413 gracefully when reporting a bug #994

Closed

Issue webcompat#929 - Removing GitHubError as 401 error code is alrea…

f74e23d

…dy handled

karlcow reviewed Apr 14, 2016
View reviewed changes

webcompat/views.py

@@ -44,8 +43,7 @@

404: 'Not Found. Lost in Punk Cat Space',

429: 'Cool your jets! Please wait {0} seconds before making'

'another search.',

This comment was marked as abuse.

Sign in to view

Issue webcompat#929 - AAdded trailing space in the message for error …

428d52b

…code 429

Issue webcompat#929 - Added extra blank line before error codes

aeeaff0

karlcow merged commit 6269b77 into webcompat:master Apr 15, 2016

miketaylr added the status: add to changelog label Apr 19, 2016

miketaylr removed the status: add to changelog label Apr 25, 2016

MaxMood96 mentioned this pull request Jun 24, 2023

[Snyk] Fix for 1 vulnerabilities MaxMood96/webcompat.com#70

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #929 - Make Error management more DRY #958

Fix #929 - Make Error management more DRY #958

deepthivenkat commented Mar 10, 2016

This comment was marked as abuse.

karlcow commented Mar 11, 2016

deepthivenkat commented Mar 11, 2016

deepthivenkat commented Mar 11, 2016

karlcow commented Mar 14, 2016

karlcow commented Mar 14, 2016

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

karlcow commented Apr 14, 2016

karlcow commented Apr 14, 2016

karlcow commented Apr 15, 2016

miketaylr commented Apr 19, 2016

miketaylr commented Apr 19, 2016

Fix #929 - Make Error management more DRY #958

Fix #929 - Make Error management more DRY #958

Conversation

deepthivenkat commented Mar 10, 2016

This comment was marked as abuse.

karlcow commented Mar 11, 2016

deepthivenkat commented Mar 11, 2016

deepthivenkat commented Mar 11, 2016

karlcow commented Mar 14, 2016

karlcow commented Mar 14, 2016

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

karlcow commented Apr 14, 2016

karlcow commented Apr 14, 2016

karlcow commented Apr 15, 2016

miketaylr commented Apr 19, 2016

miketaylr commented Apr 19, 2016