Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[slottable-request] Use Symbol.for() for the remove sentinel value #69

Merged
merged 1 commit into from
Jan 14, 2025
Merged

[slottable-request] Use Symbol.for() for the remove sentinel value #69

merged 1 commit into from
Jan 14, 2025

Conversation

tbroyer
Copy link
Contributor

@tbroyer tbroyer commented Jan 14, 2025

Westbrook
Westbrook approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! 🙇🏼

This jibes with my understand of Symbol and the protocol at large. @justinfagnani or @kevinpschaaf, any qualms on this?

@justinfagnani
Copy link
Member

This is definitely an improvement over status quo, but I wonder if there's a different API shape that could not require a sentinel at all? May similar to mutation records.

@justinfagnani justinfagnani merged commit 4f79699 into webcomponents-cg:main Jan 14, 2025
@tbroyer tbroyer deleted the patch-1 branch January 14, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Westbrook Westbrook Westbrook approved these changes

@justinfagnani justinfagnani justinfagnani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbroyer @justinfagnani @Westbrook