Fix advanced AngularJS array and props tests #211
Conversation
|
@robdodson any chance I can get feedback on this pull request? |
robdodson
left a comment
robdodson
left a comment
There was a problem hiding this comment.
Sorry for the delay! Commented.
| let root = prep("<comp-with-props>") | ||
| scope.$digest() | ||
| let wc = root.querySelector('#wc') | ||
| let data = wc.arr || wc.getAttribute('arr') |
There was a problem hiding this comment.
It shouldn't be calling getAttribute here. For arrays and objects, the test is trying to assert that they are always passed as JS properties.
| let root = prep("<comp-with-props>") | ||
| scope.$digest() | ||
| let wc = root.querySelector('#wc') | ||
| let data = wc.obj || wc.getAttribute('obj') |
robdodson
left a comment
robdodson
left a comment
There was a problem hiding this comment.
oops. meant to click 'request changes'.
antgonzales
force-pushed
the
fix/advanced-angularjs-tests
branch
from
fad5f9a to
8d51383
Compare
|
@robdodson thanks for the feedback! Fixed. |
|
Just started reviewing :) |
Sent from
|
Looks good. Since I'm totally not an AngularJS expert, can you explain a bit about what this change actually does? I noticed the test still fails (which is what I expected because AngularJS isn't setting properties here). But I was just curious what all the setup work does. |
|
Happy to explain! What I'm doing is compiling isolated instances of the angular components that are supposed to pass more complicated data to the child custom elements inside. Since Here's the angular component that wasn't getting rendered before: It now correctly compiles the angular component with properties/array and tests if the custom element inside is receiving them. |
|
Cool, thanks for the PR! |
2 participants
The current tests don't setup the components to test these attributes against expectations.