Latest hyperHTML with proper Custom Elements initialization #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to issue [#671](WICG/webcomponents#671) it is not possible to synchronously set attributes passing through the custom element prototype when an element comes from a template and it's not already live. Previous version of hyperHTML was somehow cheating and attaching properties to the element directly, shadowing its inherited behaviour after upgrade to CE. The issue is explained in here: WICG/webcomponents#671 (comment) This PR uses live nodes instad of template one so that the test passes without needing any special tratment.
|
P.S. instead of using asynchronous tests, I now use live nodes like any other library so that properties test passed without any issue. |
|
Sorry meant to merge this while following up on the other threads last night. Looks good to me, thanks for the update :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to issue #671
it is not possible to synchronously set attributes passing
through the custom element prototype when an element
comes from a template and it's not already live.
Previous version of hyperHTML was somehow cheating and
attaching properties to the element directly,
shadowing its inherited behaviour after upgrade to CE.
The issue is explained in here:
WICG/webcomponents#671 (comment)
This PR uses live nodes instad of template one
so that the test passes without needing any special tratment.