Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix styling in browser table #1087

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Fix styling in browser table #1087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions client/src/browser-table.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,25 @@

/* Spec label */

div[label] {
[spec] {
flex: 0 0 170px;
display: flex;
margin-right: 16px;
color: var(--theme-blue-small);
}

[spec] div[label] {
display: flex;
align-items: center;
}

div[label] svg {
[spec] svg {
width: 26px;
margin-right: 8px;
fill: var(--theme-blue-grey, #697785);
}

div[label]:after {
[spec] div[label]:after {
content: attr(label);
display: inline-block;
}
Expand All @@ -79,13 +84,13 @@
align-items: center;
}

.row > :not([label]) {
.row > :not([spec]) {
flex: 1 1 60px;
padding: 8px 0;
font-weight: bold;
}

div.header > div.row > div:not([label]), div.row [title] {
div.header > div.row > div:not([spec]), div.row [title] {
display: flex;
align-items: center;
margin: 8px 0;
Expand All @@ -102,7 +107,7 @@
margin-right: 8px;
}

div:not(.header) > div.row > :not([title]):not([label]) {
div:not(.header) > div.row > :not([title]):not([spec]) {
flex-direction: column;
}

Expand Down Expand Up @@ -203,7 +208,6 @@
<div class="header">
<h1 label>Browser support</h1>
<div class="row">
<div label=""></div>
<div>
<img src="/assets/chrome.png">
<span>Chrome</span>
Expand All @@ -227,7 +231,7 @@ <h1 label>Browser support</h1>
</div>
</div>
<div class="row">
<a href="https://html.spec.whatwg.org/multipage/scripting.html#the-template-element" target="__blank" rel="noopener">
<a spec href="https://html.spec.whatwg.org/multipage/scripting.html#the-template-element" target="_blank" rel="noopener">
<div label="Templates"><svg viewBox="0 0 26 22"><use xlink:href="/sprite.octicons.svg#template"></use></svg></div>
</a>
<a title="Stable" href="https://www.chromestatus.com/feature/5207287069147136"></a>
Expand All @@ -237,7 +241,7 @@ <h1 label>Browser support</h1>
<a title="Stable" href="https://developer.microsoft.com/en-us/microsoft-edge/platform/status/templateelement/"></a>
</div>
<div class="row">
<a href="https://w3c.github.io/webcomponents/spec/custom/" target="__blank" rel="noopener">
<a spec href="https://w3c.github.io/webcomponents/spec/custom/" target="_blank" rel="noopener">
<div label="Custom elements"><svg viewBox="0 0 26 22"><use xlink:href="/sprite.octicons.svg#element"></use></svg></div>
</a>
<a title="Stable" href="https://www.chromestatus.com/feature/4696261944934400"></a>
Expand All @@ -253,7 +257,7 @@ <h1 label>Browser support</h1>
</a>
</div>
<div class="row">
<a href="https://dom.spec.whatwg.org/#shadow-trees" target="__blank" rel="noopener">
<a spec href="https://dom.spec.whatwg.org/#shadow-trees" target="_blank" rel="noopener">
<div label="Shadow DOM"><svg viewBox="0 0 26 22"><use xlink:href="/sprite.octicons.svg#shadow"></use></svg></div>
</a>
<a title="Stable" href="https://www.chromestatus.com/feature/4667415417847808"></a>
Expand All @@ -269,7 +273,7 @@ <h1 label>Browser support</h1>
</a>
</div>
<div class="row">
<a href="https://html.spec.whatwg.org/multipage/webappapis.html#integration-with-the-javascript-module-system" target="__blank" rel="noopener">
<a spec href="https://html.spec.whatwg.org/multipag/webappapis.html#integration-with-the-javascript-module-system" target="_blank" rel="noopener">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The multipage was correct. It results in a 404 now 😢

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad!

<div label='<script type="module">'><svg viewBox="0 0 26 22"><use xlink:href="/sprite.octicons.svg#import"></use></svg></div>
</a>
<a title="Stable" href="https://www.chromestatus.com/feature/5365692190687232"></a>
Expand All @@ -279,7 +283,9 @@ <h1 label>Browser support</h1>
<a title="Stable" href="https://developer.microsoft.com/en-us/microsoft-edge/platform/status/moduleses6/"></a>
</div>
<div class="row">
<div label="HTML imports"><svg viewBox="0 0 26 22"><use xlink:href="/sprite.octicons.svg#import"></use></svg></div>
<a spec href="https://www.w3.org/TR/html-imports/" target="_blank" rel="noopener">
<div label="HTML imports"><svg viewBox="0 0 26 22"><use xlink:href="/sprite.octicons.svg#import"></use></svg></div>
</a>
<a title="Stable" href="https://www.chromestatus.com/feature/5144752345317376"></a>
<a title="Stable" href="https://www.chromestatus.com/feature/5144752345317376"></a>
<a href="https://webkit.org/status/#feature-html-imports">
Expand Down