Updated options schema

webdeveric · Dec 3, 2020 · 5059297 · 5059297
1 parent 4272dd4
commit 5059297
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/options-schema.json b/src/options-schema.json
@@ -2,6 +2,7 @@
   "title": "Webpack Assets Manifest options schema",
   "description": "Webpack Assets Manifest options",
   "type": "object",
+  "additionalProperties": false,
   "properties": {
     "enabled": {
       "type": "boolean",

diff --git a/test/WebpackAssetsManifest-test.js b/test/WebpackAssetsManifest-test.js
@@ -959,6 +959,17 @@ describe('WebpackAssetsManifest', function() {
           );
         }).to.throw();
       });
+
+      it('Error is thrown when options has unknown property', function() {
+        expect(() => {
+          create(
+            configs.hello(),
+            {
+              someUnknownProperty: 'will fail',
+            },
+          );
+        }).to.throw();
+      });
     });
   });
 
@@ -1017,7 +1028,7 @@ describe('WebpackAssetsManifest', function() {
     describe('Options', function() {
       it('Options can be altered with a hook', function() {
         const mock = chai.spy( options => {
-          options.testing = true;
+          options.space = 0;
 
           return options;
         });
@@ -1032,7 +1043,7 @@ describe('WebpackAssetsManifest', function() {
 
         expect( mock ).to.have.been.called();
 
-        expect( manifest.options.testing ).to.be.true;
+        expect( manifest.options.space ).to.equal(0);
       });
     });