Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTC fixes #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

UTC fixes #14

wants to merge 1 commit into from

Conversation

thapar
Copy link
Contributor

@thapar thapar commented Feb 26, 2015

Although #13 removed some troubling code, there still seems to be an issue where SugarJS is maintaining the timezone of the user and mixing it up with the time zone of the server (it seems). Forcing the GmailScheduler script to use UTC is the sane solution to dealing with people in different time zones.

HOWEVER, before merging this pull request, I highly recommend you create a new Google Apps Script project and transfer your current project there to use as a test project. Put this code in that new Google Apps Script project, which will serve as a sandbox. Then enable me (or anyone else in a different timezone as you) to test the script by checking the Log window in Google Apps' script editor.

Although webdigi#13 removed some troubling code, there still seems to be an issue where SugarJS is maintaining the timezone of the user and mixing it up with the time zone of the server (it seems). Forcing the GmailScheduler script to use UTC is the sane solution to dealing with people in different time zones.

HOWEVER, before merging this pull request, I highly recommend you create a new Google Apps Script project and transfer your current project there to use as a test project. Put this code in that new Google Apps Script project, which will serve as a sandbox. Then enable me (or anyone else in a different timezone as you) to test the script by checking the Log window in Google Apps' script editor.
@thapar
Copy link
Contributor Author

thapar commented Feb 26, 2015

Upon further inspection, this may be the culprit:
https://code.google.com/p/google-apps-script-issues/issues/detail?id=2845

Meaning we will need to manually calculate the timezone offset from the UTC and then do some math before showing the user a time.

@webdigi
Copy link
Owner

webdigi commented Feb 26, 2015

@thapar - Please upload https://github.com/webdigi/GmailScheduler/tree/master/src under your account. We can then test that fully under the account you create. Since you are an active contributor it might be best if you have a separate working copy in your google scripts account.

@thapar
Copy link
Contributor Author

thapar commented Feb 26, 2015

I do have a working copy. But it doesn't help me to test since I'm in my
own timezone :-) Therefore, if you create a second copy for testing under
your account, I can test that copy for the timezone issue.

On Thu, Feb 26, 2015 at 3:26 AM, Webdigi - Web Development <
notifications@github.com> wrote:

@thapar https://github.com/thapar - Please upload
https://github.com/webdigi/GmailScheduler/tree/master/src under your
account. We can then test that fully under the account you create. Since
you are an active contributor it might be best if you have a separate
working copy in your google scripts account.


Reply to this email directly or view it on GitHub
#14 (comment).

@webdigi
Copy link
Owner

webdigi commented Feb 26, 2015

Yes, understood.
Can you please paste a screenshot of Scripts (of your demo install) -> File -> Project properties and change the timezone. You should be able to change that timezone to test.

@thapar
Copy link
Contributor Author

thapar commented Feb 26, 2015

Changing that timezone changes the whole timezone in use, so that doesn't
help in testing. I can provide the screenshot, but I'd need your private
email address to send it.

On Thu, Feb 26, 2015 at 3:43 AM, Webdigi - Web Development <
notifications@github.com> wrote:

Yes, understood.
Can you please paste a screenshot of Scripts (of your demo install) ->
File -> Project properties and change the timezone. You should be able to
change that timezone to test.


Reply to this email directly or view it on GitHub
#14 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants