Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when if connectExisting passed to driver then args shouldn't include websocketPort #509

Merged
merged 2 commits into from
Aug 16, 2024
Merged

when if connectExisting passed to driver then args shouldn't include websocketPort #509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2296bd
fix: add condition to websocketPort parameter
b68h4 Aug 11, 2024
4c817ec
fix: throw an error if both parameters
b68h4 Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,20 @@ export async function start (params: GeckodriverParameters) {

startArgs.host = startArgs.host || DEFAULT_HOSTNAME

// By default, Geckodriver uses port 9222
// User might pass a port for custom runs but they should modify them for each worker
// For remaining use cases, to enable parallel instances we need to set the port to 0 (random)
// Otherwise all instances try to connect to the default port and fail
startArgs.websocketPort = startArgs.websocketPort ?? 0
// By default, Geckodriver uses port 9222.
// Users may specify a custom port for individual runs, but they need to modify it for each worker.
// For other cases, to enable parallel instances, we need to set the port to 0 (random).
// Otherwise, all instances will attempt to connect to the default port and fail.
// If both --connect-existing and --websocket-port are used together, an error is thrown.
// However, if --connect-existing is not used and --websocket-port is not specified, the websocketPort is set to 0.
if (startArgs.connectExisting && startArgs.websocketPort) {
throw new Error(
"Cannot use --connect-existing and --websocket-port together"
);
} else if (!startArgs.connectExisting && !startArgs.websocketPort) {
startArgs.websocketPort = 0;
}


const args = parseParams(startArgs)
log.info(`Starting Geckodriver at ${geckoDriverPath} with params: ${args.join(' ')}`)
Expand Down
Loading