Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return to fs-extra in onRunnerEnd method #164

Merged
merged 4 commits into from
May 30, 2023
Merged

Return to fs-extra in onRunnerEnd method #164

merged 4 commits into from
May 30, 2023

Conversation

HannaTarasevich
Copy link
Contributor

@HannaTarasevich HannaTarasevich commented May 28, 2023

To resolve #163 issue.
(issue: Sometimes JSON files generated empty or not full JSON generated (5 and higher versions only))

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, otherwise this looks good

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit 00e78e2 into webdriverio-community:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes JSON files generated empty or not full JSON generated (5 and higher versions only)
2 participants