Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fail fast when docker is not installed #134

Merged
merged 2 commits into from
Mar 7, 2024
Merged

feat: Fail fast when docker is not installed #134

merged 2 commits into from
Mar 7, 2024

Conversation

seanpoulter
Copy link
Contributor

Description

  • refactor: Use async/await instead of chained Promises
  • feat: Throw a SevereServiceError when docker is not installed

Checklist

  • Unit/Integration test added (if applicable)
  • Documentation added/updated (wiki or md)
  • Code style is consistent with the rest of the project

Notes

christian-bromann
christian-bromann approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@seanpoulter
Copy link
Contributor Author

Thanks for the review! Let's 🚢 it.
The checks will fail until we get a current version of ChromeDriver.

@seanpoulter seanpoulter merged commit 37e7ba7 into webdriverio-community:master Mar 7, 2024
1 check failed
@seanpoulter seanpoulter deleted the refactor branch March 22, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: Should we fail faster when docker is not found?
2 participants
@seanpoulter @christian-bromann