Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cid from context when getting browser name #9

Merged
merged 1 commit into from
Aug 15, 2016

Conversation

azz
Copy link
Contributor

@azz azz commented Aug 13, 2016

The [browser] parameter for the TeamCity name property was not being filled in in my case. Upon inspection the reason is that the session isn't always at ctx.runner['0'], it is ctx.runner[ctx.cid].

Example ctx:

{ type: 'test:end',
  title: 'c',
  parent: '<name>',
  pending: false,
  file: '<path>.js',
  cid: '1a',
  specs: [ '<path>.js' ],
  event: 'test:end',
  runner: { '1a': { browserName: 'internet explorer' } },
  specHash: '<hash>' }

@mightyaleksey
Copy link
Member

Hi,

Actually I didn't think that cid can change. Thank you for your effort!

I'll publish it with the next minor version.

@mightyaleksey mightyaleksey merged commit 508dff4 into webdriverio-community:master Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants