Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let jasmine swallow errors by ignoring its expectationResultHandler #3240

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

christian-bromann
Copy link
Member

Proposed changes

Currently Jasmine is swallowing errors if an expectationResultHandler is set without doing anything. This patch fixes this. It will ensure that the original handler is always called but the user still has the ability to change the assertion outcome.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 3, 2019
@christian-bromann christian-bromann self-assigned this Jan 3, 2019
@christian-bromann christian-bromann requested a review from a team January 3, 2019 23:11
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #3240 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3240      +/-   ##
==========================================
+ Coverage   96.44%   96.48%   +0.04%     
==========================================
  Files         131      131              
  Lines        2810     2848      +38     
  Branches      607      618      +11     
==========================================
+ Hits         2710     2748      +38     
  Misses         90       90              
  Partials       10       10
Impacted Files Coverage Δ
packages/wdio-jasmine-framework/src/index.js 100% <100%> (ø) ⬆️
packages/wdio-runner/src/reporter.js 100% <0%> (ø) ⬆️
...kages/webdriverio/src/commands/element/addValue.js 100% <0%> (ø) ⬆️
...es/webdriverio/src/commands/element/getProperty.js 100% <0%> (ø) ⬆️
...kages/webdriverio/src/commands/element/setValue.js 100% <0%> (ø) ⬆️
...kages/webdriverio/src/commands/element/getValue.js 100% <0%> (ø) ⬆️
...erio/src/commands/element/isDisplayedInViewport.js 100% <0%> (ø) ⬆️
...ges/webdriverio/src/commands/element/isExisting.js 100% <0%> (ø) ⬆️
...es/webdriverio/src/commands/element/doubleClick.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486e721...1b6e634. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant