Don't let jasmine swallow errors by ignoring its expectationResultHandler #3240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently Jasmine is swallowing errors if an
expectationResultHandler
is set without doing anything. This patch fixes this. It will ensure that the original handler is always called but the user still has the ability to change the assertion outcome.Types of changes
Checklist
Further comments
Reviewers: @webdriverio/technical-committee