Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hook bug - closes #3333 #3334

Merged
merged 1 commit into from
Jan 15, 2019
Merged

fix hook bug - closes #3333 #3334

merged 1 commit into from
Jan 15, 2019

Conversation

christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Jan 15, 2019

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 15, 2019
@xlenz
Copy link

xlenz commented Jan 15, 2019

@christian-bromann works fine for me. How have you managed to do it so fast :)

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #3334 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3334   +/-   ##
=======================================
  Coverage   96.79%   96.79%           
=======================================
  Files         131      131           
  Lines        2869     2869           
  Branches      623      623           
=======================================
  Hits         2777     2777           
  Misses         86       86           
  Partials        6        6
Impacted Files Coverage Δ
packages/wdio-config/src/constants.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb2239...63f4867. Read the comment docs.

@christian-bromann
Copy link
Member Author

How have you managed to do it so fast :)

I've been written the code and know where to move the knobs. Thanks for raising the issue so quick. Will do a release right after.

@christian-bromann christian-bromann merged commit b60ea15 into master Jan 15, 2019
@christian-bromann christian-bromann deleted the cb-hook-fix2 branch January 15, 2019 12:00
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Jun 13, 2019
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants