Issue 3416: Allow the spec reporter to expose multiple errors if present #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3702 +/- ##
==========================================
+ Coverage 98.32% 98.32% +<.01%
==========================================
Files 144 144
Lines 3285 3289 +4
Branches 720 721 +1
==========================================
+ Hits 3230 3234 +4
Misses 50 50
Partials 5 5
Continue to review full report at Codecov.
|
christian-bromann
added
the
PR: Polish 💅
yamkay
pushed a commit
to MoveInc/webdriverio
that referenced
this pull request
Sep 4, 2019
…ent (webdriverio#3702) ## Proposed changes Continuing on [https://github.com/webdriverio/webdriverio/pull/3672](https://github.com/webdriverio/webdriverio/pull/3672) This PR prints out multiple errors with the spec reporter if they are present. It pretty well emulates the behavior of other spec-style Jasmine reporters. ## Types of changes - [X] Bugfix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist [//]: # (_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._) - [X] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [X] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) ### Reviewers: @webdriverio/technical-committee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Continuing on #3672
This PR prints out multiple errors with the spec reporter if they are present. It pretty well emulates the behavior of other spec-style Jasmine reporters.
Types of changes
Checklist
Reviewers: @webdriverio/technical-committee