'name' find strategy should be used if isMobile is used even when w3c is used #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…even when w3c is used
Codecov Report
@@ Coverage Diff @@
## master #3739 +/- ##
==========================================
+ Coverage 98.33% 98.33% +<.01%
==========================================
Files 145 145
Lines 3307 3308 +1
Branches 725 725
==========================================
+ Hits 3252 3253 +1
Misses 50 50
Partials 5 5
Continue to review full report at Codecov.
|
6 tasks
yamkay
pushed a commit
to MoveInc/webdriverio
that referenced
this pull request
Sep 4, 2019
… is used (webdriverio#3739) ## Proposed changes [//]: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.) Fix webdriverio#3738 . Inside `findStrategy` method we have a logic that uses `css selector` in case when `w3c` is `true`. When running tests on mobile (`isMobile` is `true`) it should use `name` anyway. ## Types of changes [//]: # (What types of changes does your code introduce to WebdriverIO?) [//]: # (_Put an `x` in the boxes that apply_) - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist [//]: # (_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._) - [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) ## Further comments [//]: # (If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...) ### Reviewers: @webdriverio/technical-committee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix #3738 . Inside
findStrategymethod we have a logic that usescss selectorin case whenw3cistrue. When running tests on mobile (isMobileistrue) it should usenameanyway.Types of changes
Checklist
Further comments
Reviewers: @webdriverio/technical-committee