Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webdriver: truncate screen recording log #4251 #4252

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

mooyoul
Copy link
Contributor

@mooyoul mooyoul commented Jul 24, 2019

Proposed changes

Truncate result before logging if given command is screen recording related

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixes #4251

Reviewers: @webdriverio/technical-committee

@jsf-clabot
Copy link

jsf-clabot commented Jul 24, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #4252 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4252   +/-   ##
=======================================
  Coverage   99.35%   99.35%           
=======================================
  Files         175      175           
  Lines        4324     4324           
  Branches      926      926           
=======================================
  Hits         4296     4296           
  Misses         25       25           
  Partials        3        3
Impacted Files Coverage Δ
packages/webdriver/src/command.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260b9df...2749bb3. Read the comment docs.

Copy link
Member

@mgrybyk mgrybyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jul 25, 2019
@christian-bromann christian-bromann merged commit b85a064 into webdriverio:master Jul 25, 2019
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Truncate screen record command result log
4 participants