Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dragAndDrop respect scroll position #4302

Merged
merged 2 commits into from
Aug 5, 2019
Merged

Make dragAndDrop respect scroll position #4302

merged 2 commits into from
Aug 5, 2019

Conversation

mgrybyk
Copy link
Member

@mgrybyk mgrybyk commented Aug 3, 2019

Proposed changes

Fix dragAndDrop in w3c mode, make it respect scroll position
fixes #4246

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@codecov
Copy link

codecov bot commented Aug 3, 2019

Codecov Report

Merging #4302 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4302      +/-   ##
==========================================
+ Coverage   99.35%   99.35%   +<.01%     
==========================================
  Files         175      175              
  Lines        4333     4336       +3     
  Branches      932      932              
==========================================
+ Hits         4305     4308       +3     
  Misses         25       25              
  Partials        3        3
Impacted Files Coverage Δ
...ackages/webdriverio/src/commands/element/moveTo.js 100% <100%> (ø) ⬆️
packages/webdriverio/src/utils.js 100% <100%> (ø) ⬆️
...es/webdriverio/src/commands/element/dragAndDrop.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 705ec8f...bcb86a8. Read the comment docs.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit ea98a1e into webdriverio:master Aug 5, 2019
@mgrybyk mgrybyk deleted the fix-drag-n-drop branch August 20, 2019 07:22
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
* webdriverio: make drag n drop respect scroll position

* webdriverio: fix moveTo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dragAndDrop and moveTo don't seem to work on chrome headless
2 participants