Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junit cucumber reporting fix #6464

Merged

Conversation

AutomationReddy
Copy link
Member

Proposed changes

This PR fixes the issue that occurs in latest cucumber update where Junit report building was not happening properly.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works

Further comments

Reviewers: @webdriverio/project-committers

fixed junit cucumber reporting

fixed junit cucumber reporting
Copy link
Member

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you check the syntax for the if/else statement?

packages/wdio-junit-reporter/src/index.ts Outdated Show resolved Hide resolved
packages/wdio-junit-reporter/src/index.ts Outdated Show resolved Hide resolved
packages/wdio-junit-reporter/src/index.ts Outdated Show resolved Hide resolved
packages/wdio-junit-reporter/src/index.ts Outdated Show resolved Hide resolved
@AutomationReddy AutomationReddy force-pushed the junit_cucumber_fix branch 3 times, most recently from 54e8190 to f72fa73 Compare February 18, 2021 15:03
Junit Cucumber Report Fix
@AutomationReddy
Copy link
Member Author

@christian-bromann @wswebcreation Addressed the comments. Also, added an unit test which covers the case when suites JSON is unordered

@christian-bromann
Copy link
Member

christian-bromann commented Mar 2, 2021

@AutomationReddy can you update your branch? It should resolve the build issues and we can go ahead merge.

@AutomationReddy
Copy link
Member Author

AutomationReddy commented Mar 2, 2021 via email

@igivon
Copy link

igivon commented Mar 8, 2021

any update?

@AutomationReddy
Copy link
Member Author

@AutomationReddy can you update your branch? It should resolve the build issues and we can go ahead merge.

@christian-bromann Updated. Please check

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AutomationReddy 👍

This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants