-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Junit cucumber reporting fix #6464
Junit cucumber reporting fix #6464
Conversation
fixed junit cucumber reporting fixed junit cucumber reporting
133e9cd
to
2943ac3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you check the syntax for the if/else statement?
54e8190
to
f72fa73
Compare
Junit Cucumber Report Fix
f72fa73
to
af4e069
Compare
@christian-bromann @wswebcreation Addressed the comments. Also, added an unit test which covers the case when suites JSON is unordered |
@AutomationReddy can you update your branch? It should resolve the build issues and we can go ahead merge. |
Will update this tonight
…On Tue, 2 Mar 2021 at 3:51 PM, Christian Bromann ***@***.***> wrote:
@AutomationReddy <https://github.com/AutomationReddy> can you update your
branch? It should resolve the issues and we can go ahead merge.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6464 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKDCJF3YTU7FWGQ7RNEIUT3TBS3ZJANCNFSM4XYU7A7Q>
.
|
any update? |
@christian-bromann Updated. Please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AutomationReddy 👍
Proposed changes
This PR fixes the issue that occurs in latest cucumber update where Junit report building was not happening properly.
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers