Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve spec reporting for multiremote #6700

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Improve spec reporting for multiremote #6700

merged 2 commits into from
Apr 13, 2021

Conversation

christian-bromann
Copy link
Member

Proposed changes

This PR fixes:

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Apr 13, 2021
@christian-bromann christian-bromann requested a review from a team April 13, 2021 11:09
This was linked to issues Apr 13, 2021
spec-reporter saucelabs link doesn't reflect 'eu' region #6680
Closed
Saucelabs jobs links are not available to reporters in multiremote #6696
Closed
@christian-bromann christian-bromann added the needs-review These Pull Requests require review from project members label Apr 13, 2021
wswebcreation
wswebcreation approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-bromann christian-bromann merged commit 0f28880 into main Apr 13, 2021
@christian-bromann christian-bromann deleted the cb-multiremote-link-in-spec branch April 13, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wswebcreation wswebcreation wswebcreation approved these changes

Assignees
No one assigned
Labels
needs-review These Pull Requests require review from project members PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Milestone
No milestone
2 participants
@christian-bromann @wswebcreation