Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@wdio/junit-reporter: remove validator dependency #9586

Merged
merged 1 commit into from
Jan 15, 2023
Merged

@wdio/junit-reporter: remove validator dependency #9586

merged 1 commit into from
Jan 15, 2023

Conversation

SCG82
Copy link
Member

@SCG82 SCG82 commented Jan 13, 2023 •
edited
Loading

Proposed changes

Fixes #9536
Closes #9542

  • @wdio/utils: fix incorrect RegExp in isBase64 utility

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

christian-bromann
christian-bromann approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 15, 2023
@christian-bromann christian-bromann merged commit e053d0c into main Jan 15, 2023
@christian-bromann christian-bromann deleted the junit-fix-cjs branch January 15, 2023 10:23
@christian-bromann christian-bromann mentioned this pull request Jan 17, 2023
Closed
3 tasks
@christian-bromann christian-bromann mentioned this pull request Mar 24, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: @wdio-junit-reporter does not work on WDIO v8 TypeScript
2 participants
@SCG82 @christian-bromann