Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for travis-ci.com #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

djmcgill
Copy link

@djmcgill djmcgill commented Feb 4, 2019

As per this blog post: travis-ci is migrating users away from travis-ci.org to travis-ci.com but this repo only supports the former.

I've added support for an optional key tld (with possible values "org" or "com") to the travis badge which will generate badge urls for pointing to .org or .com. Any other value will be a panic.

Open questions:

  • Should there be a better mechanism than a panic?
  • How does crates.io handle the travis-ci badge, do they have support for .com?
  • I have not yet updated the docs for this change
  • Bikeshed on the key "tld". Should it be added to, e.g. "service" to specify the full url?

@livioribeiro
Copy link
Collaborator

Does the badges work if we just replace .org with .com? If yes, then we can just use .com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants