Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for segno reading #134

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

SemitoneGene
Copy link
Contributor

Segno are now read and made available in the public API.

@SemitoneGene
Copy link
Contributor Author

I also made a fix to catch.h in cpul that was causing a crash when building on the M1.

@SemitoneGene
Copy link
Contributor Author

Coda reading added as well.

@SemitoneGene
Copy link
Contributor Author

Added rehearsal reading.

In typical Gene fashion, I just realized all these changes only deal with reading. I am working on getting the writer work done.

@SemitoneGene
Copy link
Contributor Author

I stubbed in the writing functions, but need to do some more work to understand the correct way to write the info out. Any help is appreciated!

@webern
Copy link
Owner

webern commented Jan 18, 2023

I'll take a look.

@webern
Copy link
Owner

webern commented Jan 18, 2023

Your commit history lol 😅

Don't push anything else ATM, I'll fix it.

@webern
Copy link
Owner

webern commented Jan 18, 2023

I think I fixed the git history at least. I force pushed to your fork and branch (because you can do that with GitHub, it's crazy).

So, Assuming your fork is at "origin", you should:

cd mx
git remote add upstream git@github.com:webern/mx.git
git checkout master
git fetch upstream master
git reset --hard upstream/master
git push origin -f master
git fetch origin gene/351
git checkout gene/351
git reset --hard origin gene/351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants