feat(MeetingsSdkAdapter): add missing text on controls

webex · Sep 3, 2021 · c439fe7 · c439fe7
1 parent 1fd58a5
commit c439fe7
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 15 deletions.
diff --git a/src/MeetingsSDKAdapter.js b/src/MeetingsSDKAdapter.js
@@ -834,26 +834,26 @@ export default class MeetingsSDKAdapter extends MeetingsAdapter {
     const inactiveShare = {
       ID: SHARE_CONTROL,
       type: 'TOGGLE',
-      icon: 'share-screen-presence-stroke_26',
-      tooltip: 'Start Share',
       state: MeetingControlState.INACTIVE,
-      text: null,
+      icon: 'share-screen-presence-stroke_26',
+      text: 'Start sharing',
+      tooltip: 'Start Sharing',
     };
     const activeShare = {
       ID: SHARE_CONTROL,
       type: 'TOGGLE',
-      icon: 'share-screen-presence-stroke_26',
-      tooltip: 'Stop Share',
       state: MeetingControlState.ACTIVE,
-      text: null,
+      icon: 'share-screen-presence-stroke_26',
+      text: 'Stop sharing',
+      tooltip: 'Stop Sharing',
     };
     const disabledShare = {
       ID: SHARE_CONTROL,
       type: 'TOGGLE',
+      state: MeetingControlState.DISABLED,
       icon: 'share-screen-presence-stroke_26',
+      text: 'Sharing is Unavailable',
       tooltip: 'Sharing is Unavailable',
-      state: MeetingControlState.DISABLED,
-      text: null,
     };
 
     const getDisplayData$ = Observable.create((observer) => {

diff --git a/src/MeetingsSDKAdapter.test.js b/src/MeetingsSDKAdapter.test.js
@@ -724,7 +724,6 @@ describe('Meetings SDK Adapter', () => {
           ID: 'share-screen',
           type: 'TOGGLE',
           icon: 'share-screen-presence-stroke_26',
-          text: null,
         });
         done();
       });

diff --git a/src/MeetingsSDKAdapter/controls/RosterControl.js b/src/MeetingsSDKAdapter/controls/RosterControl.js
@@ -31,16 +31,18 @@ export default class RosterControl extends MeetingControl {
     const active = {
       ID: this.ID,
       type: 'TOGGLE',
+      state: MeetingControlState.ACTIVE,
       icon: 'participant-list_28',
+      text: 'Participants',
       tooltip: 'Hide participants panel',
-      state: MeetingControlState.ACTIVE,
     };
     const inactive = {
       ID: this.ID,
       type: 'TOGGLE',
+      state: MeetingControlState.INACTIVE,
       icon: 'participant-list_28',
+      text: 'Participants',
       tooltip: 'Show participants panel',
-      state: MeetingControlState.INACTIVE,
     };
 
     return this.adapter.getMeeting(meetingID).pipe(

diff --git a/src/MeetingsSDKAdapter/controls/RosterControl.test.js b/src/MeetingsSDKAdapter/controls/RosterControl.test.js
@@ -19,9 +19,10 @@ describe('Roster Control', () => {
           expect(dataDisplay).toMatchObject({
             ID: 'member-roster',
             type: 'TOGGLE',
+            state: 'inactive',
             icon: 'participant-list_28',
+            text: 'Participants',
             tooltip: 'Show participants panel',
-            state: 'inactive',
           });
         });
     });

diff --git a/src/MeetingsSDKAdapter/controls/SettingsControl.js b/src/MeetingsSDKAdapter/controls/SettingsControl.js
@@ -31,16 +31,18 @@ export default class SettingsControl extends MeetingControl {
     const active = {
       ID: this.ID,
       type: 'TOGGLE',
+      state: MeetingControlState.ACTIVE,
       icon: 'settings_32',
+      text: 'Settings',
       tooltip: 'Hide settings panel',
-      state: MeetingControlState.ACTIVE,
     };
     const inactive = {
       ID: this.ID,
       type: 'TOGGLE',
+      state: MeetingControlState.INACTIVE,
       icon: 'settings_32',
+      text: 'Settings',
       tooltip: 'Show settings panel',
-      state: MeetingControlState.INACTIVE,
     };
 
     return this.adapter.getMeeting(meetingID).pipe(

diff --git a/src/MeetingsSDKAdapter/controls/SettingsControl.test.js b/src/MeetingsSDKAdapter/controls/SettingsControl.test.js
@@ -19,9 +19,10 @@ describe('Settings Control', () => {
           expect(dataDisplay).toMatchObject({
             ID: 'settings',
             type: 'TOGGLE',
+            state: 'inactive',
             icon: 'settings_32',
+            text: 'Settings',
             tooltip: 'Show settings panel',
-            state: 'inactive',
           });
         });
     });