fix(plugin-meetings): clientSignallingProtocol stat #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
SomeBody16
force-pushed
the
WEBEX-396966-clientSignallingProtocol
branch
from
171ef4e to
3190a20
Compare
SomeBody16
requested review from
szotrabh,
brycetham,
antsukanova,
edvujic and
k-wasniowski
antsukanova
reviewed
Sep 3, 2024
packages/@webex/plugin-meetings/test/unit/spec/meeting/index.js
Outdated
Show resolved
Hide resolved
SomeBody16
force-pushed
the
WEBEX-396966-clientSignallingProtocol
branch
from
90d9826 to
fb18e56
Compare
brycetham
approved these changes
Sep 3, 2024
SomeBody16
force-pushed
the
WEBEX-396966-clientSignallingProtocol
branch
from
fb18e56 to
299fe44
Compare
bhabalan
pushed a commit
to bhabalan/webex-js-sdk
that referenced
this pull request
Sep 5, 2024
Co-authored-by: Filip Nowakowski <fnowakow@cisco.com>
pagour98
pushed a commit
to pagour98/webex-js-sdk
that referenced
this pull request
Sep 27, 2024
Co-authored-by: Filip Nowakowski <fnowakow@cisco.com>
pagour98
pushed a commit
to pagour98/webex-js-sdk
that referenced
this pull request
Sep 27, 2024
Co-authored-by: Filip Nowakowski <fnowakow@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES WEBEX-396966
This pull request addresses
Missing
clientSignallingProtocolstat in media quality eventby making the following changes
Fill
clientSignallingProtocolatmeetingJoinInfo.clientSignallingProtocolwith valueWebRTCChange Type
The following scenarios where tested
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.