fix: update internal media core version #3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvujic
requested review from
antsukanova,
szotrabh,
brycetham,
k-wasniowski and
SomeBody16
|
It would be great to add section with test cases that change works |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
brycetham
approved these changes
Sep 3, 2024
Yeah, I thought the template asked to list out the test cases. Would be good to inform the SDK what we've tested, both manually and with unit tests. |
Kesari3008
approved these changes
Sep 4, 2024
|
Please resolve the merge conflicts before merge |
antsukanova
approved these changes
Sep 4, 2024
# Conflicts: # packages/@webex/media-helpers/package.json # packages/@webex/plugin-meetings/package.json # packages/calling/package.json # yarn.lock
pagour98
pushed a commit
to pagour98/webex-js-sdk
that referenced
this pull request
Sep 27, 2024
Co-authored-by: evujici <evujici@cisco.com>
pagour98
pushed a commit
to pagour98/webex-js-sdk
that referenced
this pull request
Sep 27, 2024
Co-authored-by: evujici <evujici@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES SPARK-557155
This pull request addresses
It has been noticed that there was an issue with the
isRequestedflag for transcoded meetings. It was updated ininternal-media-core, and therefore theinternal-media-coreversion needs to be updated here as well to reflect the changes.https://sqbu-github.cisco.com/WebExSquared/webrtc-media-core/pull/264
Change Type
The following scenarios where tested
internal-media-corefor the tweakinternal-media-corelocally with the SDK to ensure it works properlyI certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly