fix(plugin-meetings): add to peer connection bare turn tcp server #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
k-wasniowski
force-pushed
the
fix-add-turn-tcp-relay-server
branch
from
bc4afc2 to
29704c1
Compare
k-wasniowski
force-pushed
the
fix-add-turn-tcp-relay-server
branch
from
29704c1 to
b60f507
Compare
k-wasniowski
commented
Sep 4, 2024
| @@ -163,6 +163,19 @@ Media.createMediaConnection = ( | |||
| // we might not have any TURN server if TURN discovery failed or wasn't done or | |||
| // we might get an empty TURN url if we land on a video mesh node | |||
| if (turnServerInfo?.url) { | |||
| if (!isBrowser('firefox')) { | |||
There was a problem hiding this comment.
Limiting it to non-firefox, as we might be not handling it properly with Full-ICE. Once we test it properly with Firefox, we should enable it also for Firefox.
marcin-bazyl
approved these changes
Sep 4, 2024
szotrabh
approved these changes
Sep 5, 2024
pagour98
pushed a commit
to pagour98/webex-js-sdk
that referenced
this pull request
Sep 27, 2024
pagour98
pushed a commit
to pagour98/webex-js-sdk
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #SPARK-559031
This pull request addresses
Sometimes TURN-TCP reachability completes succesfully, but then media fails to connect over TCP. Adding TURN-TCP to peer connection configuration, to verify if it will help in this scenario.
by making the following changes
Modifying discovered TURN-TLS to work as bare TURN-TCP server.
Change Type
The following scenarios where tested
Tested with sample app(Chrome,Edge,Firefox) and blocked UDP to force connections over TCP.
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.