-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-meetings): add retry mechanism to fetching clusters #3813
Merged
k-wasniowski
merged 7 commits into
webex:next
from
k-wasniowski:fix-plugin-meetings-implement-retry-fetching-clusters
Sep 17, 2024
Merged
fix(plugin-meetings): add retry mechanism to fetching clusters #3813
k-wasniowski
merged 7 commits into
webex:next
from
k-wasniowski:fix-plugin-meetings-implement-retry-fetching-clusters
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-wasniowski
force-pushed
the
fix-plugin-meetings-implement-retry-fetching-clusters
branch
from
September 6, 2024 12:28
89bd834
to
b67fa46
Compare
This pull request is automatically being deployed by Amplify Hosting (learn more). |
k-wasniowski
force-pushed
the
fix-plugin-meetings-implement-retry-fetching-clusters
branch
from
September 6, 2024 13:13
b67fa46
to
aced81c
Compare
marcin-bazyl
approved these changes
Sep 16, 2024
szotrabh
approved these changes
Sep 17, 2024
k-wasniowski
deleted the
fix-plugin-meetings-implement-retry-fetching-clusters
branch
September 17, 2024 08:07
pagour98
pushed a commit
to pagour98/webex-js-sdk
that referenced
this pull request
Sep 27, 2024
pagour98
pushed a commit
to pagour98/webex-js-sdk
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #SPARK-559944
This pull request addresses
Sometimes
getClusters
call fails due to network issues. For these cases, add a retry so that we would have chance to gather reachability data.by making the following changes
Add a retry mechanism for getting clusters list
Change Type
The following scenarios where tested
JS-SDK Sample app, success and failure cases.
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.