Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-meetings): add retry mechanism to fetching clusters #3813

Conversation

k-wasniowski
Copy link
Contributor

@k-wasniowski k-wasniowski commented Sep 6, 2024

COMPLETES #SPARK-559944

This pull request addresses

Sometimes getClusters call fails due to network issues. For these cases, add a retry so that we would have chance to gather reachability data.

by making the following changes

Add a retry mechanism for getting clusters list

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

JS-SDK Sample app, success and failure cases.

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@k-wasniowski k-wasniowski requested review from a team as code owners September 6, 2024 12:26
@k-wasniowski k-wasniowski force-pushed the fix-plugin-meetings-implement-retry-fetching-clusters branch from 89bd834 to b67fa46 Compare September 6, 2024 12:28
@k-wasniowski k-wasniowski removed the request for review from marcin-bazyl September 6, 2024 12:28
@k-wasniowski k-wasniowski marked this pull request as draft September 6, 2024 12:29
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3813.d3m3l2kee0btzx.amplifyapp.com

@k-wasniowski k-wasniowski force-pushed the fix-plugin-meetings-implement-retry-fetching-clusters branch from b67fa46 to aced81c Compare September 6, 2024 13:13
@k-wasniowski k-wasniowski added the validated If the pull request is validated for automation. label Sep 6, 2024
@k-wasniowski k-wasniowski marked this pull request as ready for review September 6, 2024 13:15
@k-wasniowski k-wasniowski merged commit d927e6f into webex:next Sep 17, 2024
11 checks passed
@k-wasniowski k-wasniowski deleted the fix-plugin-meetings-implement-retry-fetching-clusters branch September 17, 2024 08:07
pagour98 pushed a commit to pagour98/webex-js-sdk that referenced this pull request Sep 27, 2024
pagour98 pushed a commit to pagour98/webex-js-sdk that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants