feat(byods): create the main BYODS class implementation #3824
Conversation
bhabalan
changed the title
|
Please add the validated label for the checks to run |
- Refactored constants into a separate module for better manageability - Moved HTTP calls to BaseClient - Introduced DataSourceClient for interaction with the dataSource API - Created TokenManager to centralize token handling and refresh logic
There was a problem hiding this comment.
Please move each of the clients into a separate folder with its own types file so each folder has its own type. Common types can stay at the root.
Additionally, we should adhere to the structure used by plugin-meetings and others for the tests as the tooling looks for a directory structure similar to them.
For e.g. packages/byods/test/unit/spec/byods/index.js & packages/byods/test/unit/spec/tokenManager/index.js
bhabalan
changed the title
bhabalan
force-pushed
the
feat/byods-base-class
branch
from
56e4a36 to
f68f236
Compare
| /** | ||
| * The audience for the data source request. | ||
| */ | ||
| audience: string; |
There was a problem hiding this comment.
Question. Is audience just a string for the developer to use for context?
There was a problem hiding this comment.
Yes. It could be anything. Sort of like a note for the developer to know what the dataSource is for.
kebab-case is the general convention that we follow. For react PascalCase was introduced. |
COMPLETES #SPARK-549037
This pull request addresses
Creation of the main class for the BYoDS sdk
by making the following changes
Change Type
The following scenarios where tested
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.