fix(contacts): handle optional scim fields #3827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhmenon
reviewed
Sep 13, 2024
| if (photos?.length) { | ||
| avatarURL = photos[0].value; | ||
| let sipAddresses; | ||
| if (filteredContact[SCIM_WEBEXIDENTITY_USER]) { |
There was a problem hiding this comment.
Nit: Maybe we can use ternary operator here also.. but just a suggestion.
There was a problem hiding this comment.
@adhmenon the ternary operator doesn't work here. Something to do with the way typescript recognizes this object member. I initially tried with ternary but kept getting errors that SCIM_WEBEXIDENTITY_USER could be undefined.
adhmenon
approved these changes
Sep 13, 2024
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
pagour98
pushed a commit
to pagour98/webex-js-sdk
that referenced
this pull request
Sep 27, 2024
pagour98
pushed a commit
to pagour98/webex-js-sdk
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES # NA
This pull request addresses
Optional fields in the SCIM API response. Not all contacts will have all the fields populated and the SCIM API mandates only 3 mandatory fields. This causes a crash in our code.
by making the following changes
Mark all fields except 3 mandatory ones as optional. Handle contact resolution logic accordingly.
Added new UTs to test this optional field logic in the resolution.
Change Type
The following scenarios where tested
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.