fix(meetings): empty webrtc dumps when user closes the browser early #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-bazyl
added
the
validated
marcin-bazyl
commented
Sep 13, 2024
| this.setNewConnectionId(); | ||
| // Send the first set of metrics at 5 seconds in the case of a user leaving the call shortly after joining. | ||
| setTimeout(this.sendMetricsInQueue.bind(this), 5 * 1000); | ||
| this.resetConnection(); |
There was a problem hiding this comment.
I've renamed setNewConnectionId() to resetConnection(), because we need to reset the initialMetricsSent flag when we have a new connection, so that we upload the stats for the new connection as soon as they appear
marcin-bazyl
force-pushed
the
spark-562098
branch
from
5850d8e to
69a6039
Compare
brycetham
approved these changes
Sep 13, 2024
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
pagour98
pushed a commit
to pagour98/webex-js-sdk
that referenced
this pull request
Sep 27, 2024
pagour98
pushed a commit
to pagour98/webex-js-sdk
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #SPARK-562098
This pull request addresses
When investigating join meeting failure cases where ICE connection was successful, but RTP packets seemed to be not getting through I saw a lot of webrtc dumps that were missing the stats, they only contained the log. It's because SDK uploads the dumps 5s after connection creation and WCME also calls getStats() 5s after connection creation, but it's just after the SDK timer, so the metrics that get uploaded don't have the result of the 1st getStats() call.
by making the following changes
Changed SDK to do the first upload as soon as we get a first stats-report.
Change Type
The following scenarios where tested
unit tests and manual run with the web app
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.