-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstreamsvcs #3832
Upstreamsvcs #3832
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
@chrisadubois the SDK doesn't send |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment regarding the decision to add includeUpstreamServices
@sreenara - that's actually exactly what this helps with for the future. upstream services are not limited to just the catalog. The default is |
We are setting it to |
@sreenara please also have a look at this wiki: https://confluence-eng-gpk2.cisco.com/conf/pages/viewpage.action?spaceKey=WBXT&title=Making+WDM+Upstream+Requests+optional+for+clients |
COMPLETES #< INSERT LINK TO ISSUE >
This pull request addresses
Making energy forecast data an option for the WDM register and refresh calls
all
doesn't change the current request, it is the default as we have today, we can use it to expand and request only certain parts from WDM from upstream services in the future.https://confluence-eng-gpk2.cisco.com/conf/pages/viewpage.action?spaceKey=WBXT&title=Making+WDM+Upstream+Requests+optional+for+clients
Change Type
The following scenarios where tested
manual and unit tests
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
I certified that
Make sure to have followed the contributing guidelines before submitting.