Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstreamsvcs #3832

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Upstreamsvcs #3832

merged 6 commits into from
Sep 16, 2024

Conversation

chrisadubois
Copy link
Collaborator

@chrisadubois chrisadubois commented Sep 13, 2024

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

Making energy forecast data an option for the WDM register and refresh calls

all doesn't change the current request, it is the default as we have today, we can use it to expand and request only certain parts from WDM from upstream services in the future.

https://confluence-eng-gpk2.cisco.com/conf/pages/viewpage.action?spaceKey=WBXT&title=Making+WDM+Upstream+Requests+optional+for+clients

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

manual and unit tests

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@chrisadubois chrisadubois requested review from a team as code owners September 13, 2024 19:16
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3832.d3m3l2kee0btzx.amplifyapp.com

@chrisadubois chrisadubois added the validated If the pull request is validated for automation. label Sep 13, 2024
@sreenara
Copy link
Contributor

all doesn't change the current request, it is the default as we have today, we can use it to expand and request only certain parts from WDM from upstream services in the future.

@chrisadubois the SDK doesn't send IncludeUpstreamService right now while doing WDM registration. Why are we adding this considering the link between WDM and U2C is going to be removed in the future. Reference

Copy link
Contributor

@sreenara sreenara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment regarding the decision to add includeUpstreamServices

@chrisadubois
Copy link
Collaborator Author

@sreenara - that's actually exactly what this helps with for the future. upstream services are not limited to just the catalog. The default is all. Once the catalog is removed, that is fine, there are still settings, toggles, etc which are ALSO upstream services. In fact, we could build on this after this PR and remove the u2c reference right away via this query parameter and not include the catalog in the WDM response.

@chrisadubois
Copy link
Collaborator Author

We are setting it to all because today, that is existing functionality. Next step would be to provide the list of upstream services sans u2c/catalog

@chrisadubois
Copy link
Collaborator Author

@chrisadubois chrisadubois merged commit 4c321d2 into webex:next Sep 16, 2024
11 checks passed
pagour98 pushed a commit to pagour98/webex-js-sdk that referenced this pull request Sep 27, 2024
pagour98 pushed a commit to pagour98/webex-js-sdk that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants