Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contacts): use webexapis.com url to avoid cors #3834

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

sreenara
Copy link
Contributor

@sreenara sreenara commented Sep 14, 2024

COMPLETES # NA

This pull request addresses

CORS issues faced by the SCIM requests because we are directly contacting identity.webex.com instead of the API GW.

by making the following changes

SCIM query will now use https://webexapis.com and https://integration.webexapis.com for resolution of users as this has been indicated as the correct manner by the SCIM team.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

  1. Created a cloud contact on BTS and PROD environments
  2. Deleted contact group in BTS
  3. Checked Call Settings for user in PROD and BTS environments.
  4. Tested incoming and outgoing call. Contact resolutions worked fine.

ZIP file attached with console logs and HAR from tests.
SDK_CORS_SCIM_tests.zip

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@sreenara sreenara requested a review from a team as a code owner September 14, 2024 11:51
@sreenara sreenara added the validated If the pull request is validated for automation. label Sep 14, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3834.d3m3l2kee0btzx.amplifyapp.com

@sreenara sreenara merged commit 1de73b3 into webex:next Sep 14, 2024
11 checks passed
@sreenara sreenara deleted the use-webexapis branch September 15, 2024 14:52
pagour98 pushed a commit to pagour98/webex-js-sdk that referenced this pull request Sep 27, 2024
pagour98 pushed a commit to pagour98/webex-js-sdk that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant