fix(meetings): webrtc dumps are sometimes empty when users join a meeting via lobby #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-bazyl
commented
Sep 16, 2024
| @@ -192,15 +190,13 @@ Media.createMediaConnection = ( | |||
| config.bundlePolicy = bundlePolicy; | |||
| } | |||
|
|
|||
| const rtcMetrics = new RtcMetrics(webex, meetingId, correlationId); | |||
There was a problem hiding this comment.
I had to move this to Meeting.createMediaConnection() so that I could store the reference to RtcMetricsas a private field of theMeeting. This way we can call this.rtcMetrics.sendNextMetrics()` when we are admitted into the meeting.
marcin-bazyl
added
the
validated
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
jor-row
approved these changes
Sep 16, 2024
pagour98
pushed a commit
to pagour98/webex-js-sdk
that referenced
this pull request
Sep 27, 2024
pagour98
pushed a commit
to pagour98/webex-js-sdk
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #SPARK-562381
This pull request addresses
If a user joins a meeting and ends up in the lobby and later gets admitted to the meeting, it can take up to 30s before we send webrtc dump data after user is admitted to the meeting. If user has any issues, they often close the tab before we send webrtc dump data.
by making the following changes
Sending webrtc dump data sooner after being admitted. The data is collected every 5s, so it should be good enough if we just send the first batch of data we have after being admitted.
Change Type
The following scenarios where tested
unit tests, manual test run with the web app
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.