feat(meetings): do ip version detection in parallel with reachability #3838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #SPARK-562699
This pull request addresses
Orpheus team wants us to tell them if we are on an ipv4 or ipv6 network (or both) when we call the discovery/v1/clusters API. To know this we would need to gather local ICE candidates before making that call - that can take some time (few hundred milliseconds), so for now we will do this in parallel to making the API call just so that we can measure how long it takes and send the timings with reachability metrics.
by making the following changes
This means that now we'll be sending the
ipver
parameter to Locus when we're joining a meeting based on the results of ip network detection done during last reachability check. Previously we've just been always sending ipver=0 which means "we don't know if we're on ipv4 or ipv6 network")Change Type
The following scenarios where tested
unit tests
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.