Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meetings): do ip version detection in parallel with reachability #3838

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

marcin-bazyl
Copy link
Collaborator

@marcin-bazyl marcin-bazyl commented Sep 16, 2024

COMPLETES #SPARK-562699

This pull request addresses

Orpheus team wants us to tell them if we are on an ipv4 or ipv6 network (or both) when we call the discovery/v1/clusters API. To know this we would need to gather local ICE candidates before making that call - that can take some time (few hundred milliseconds), so for now we will do this in parallel to making the API call just so that we can measure how long it takes and send the timings with reachability metrics.

by making the following changes

  • starting ip network detection when we do reachability, but not waiting for it to complete
  • sending the information about how long it took in reachability metric

This means that now we'll be sending the ipver parameter to Locus when we're joining a meeting based on the results of ip network detection done during last reachability check. Previously we've just been always sending ipver=0 which means "we don't know if we're on ipv4 or ipv6 network")

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

unit tests

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3838.d3m3l2kee0btzx.amplifyapp.com

@marcin-bazyl marcin-bazyl added the validated If the pull request is validated for automation. label Sep 17, 2024
@marcin-bazyl marcin-bazyl marked this pull request as ready for review September 17, 2024 10:35
@marcin-bazyl marcin-bazyl requested review from a team as code owners September 17, 2024 10:35
Copy link
Contributor

@mkesavan13 mkesavan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do we have a separate Jira for sending the ip version later when we have the duration measured through this metric?

@marcin-bazyl
Copy link
Collaborator Author

Looks good to me. Do we have a separate Jira for sending the ip version later when we have the duration measured through this metric?

Not yet, because depending on the timings we see from the metrics, we'll decide if and how we'll do it. The Jira once created will be added to the parent epic of this PR's jira

@marcin-bazyl marcin-bazyl merged commit 11f97f5 into webex:next Sep 17, 2024
11 checks passed
pagour98 pushed a commit to pagour98/webex-js-sdk that referenced this pull request Sep 27, 2024
pagour98 pushed a commit to pagour98/webex-js-sdk that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants