Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contacts): add the resolved field to contacts #3848

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

sreenara
Copy link
Contributor

@sreenara sreenara commented Sep 20, 2024

COMPLETES # NA

This pull request addresses

The issue of unresolved contacts not being returned by the ContactsClient to the developer. When doing a SCIM query of a list of contact IDs, it is possible that SCIM doesn't resolve all of the IDs passed to it. For instance, if you pass IDs which are not present in your webex organization, SCIM will be unable to resolve these IDs and send you back the details of the ID that's passed.
The ContactsClient must still return contacts which are unresolvable through SCIM so the developer can perform additional API queries (e.g. People/XSI) to get the information they need.

by making the following changes

  1. Added a resolved field to the Contact object which indicates whether the contact was resolved or not. Developers can take action based on this field.
  2. Changed resolveCloudContacts function to return the unresolved contacts as well as the resolved ones formatted accordingly
  3. UT for the new code.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

  1. Get Cloud and Custom contacts in the samples page. Cloud contacts should have an unresolvable contact not present in the org, and this contact should show up in the final list on the samples page.
  2. Other expected functions like creating a contact, deleting a contact, creating and deleting groups.
    Vidcast: https://app.vidcast.io/share/f76d510b-a072-4982-98fa-462d134349d3

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@sreenara sreenara added the validated If the pull request is validated for automation. label Sep 20, 2024
@sreenara sreenara requested a review from a team as a code owner September 20, 2024 06:21
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3848.d3m3l2kee0btzx.amplifyapp.com

@sreenara sreenara merged commit 1eaba02 into webex:next Sep 23, 2024
11 checks passed
@sreenara sreenara deleted the fix/contacts/unresolvedContacts branch September 23, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant