feat(contacts): add the resolved field to contacts #3848
Merged
+56
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES # NA
This pull request addresses
The issue of unresolved contacts not being returned by the ContactsClient to the developer. When doing a SCIM query of a list of contact IDs, it is possible that SCIM doesn't resolve all of the IDs passed to it. For instance, if you pass IDs which are not present in your webex organization, SCIM will be unable to resolve these IDs and send you back the details of the ID that's passed.
The ContactsClient must still return contacts which are unresolvable through SCIM so the developer can perform additional API queries (e.g. People/XSI) to get the information they need.
by making the following changes
resolved
field to the Contact object which indicates whether the contact was resolved or not. Developers can take action based on this field.resolveCloudContacts
function to return the unresolved contacts as well as the resolved ones formatted accordinglyChange Type
The following scenarios where tested
Vidcast: https://app.vidcast.io/share/f76d510b-a072-4982-98fa-462d134349d3
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.