Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): test commit [ Do not review] #4020

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

feat(test): test commit [ Do not review] #4020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion docs/samples/browser-plugin-meetings/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,7 +845,7 @@ <h2 class="collapsible">

<div>
<!-- meeting-controls / transcription -->
<fieldset id="meetingControlsTranscription">
<fieldset id="meetingControlsRecordingsTranscriptionSummary">
<legend>Transcription</legend>
<div class="transcription">
<div class="btn-group u-mb">
Expand All @@ -861,6 +861,22 @@ <h2 class="collapsible">
</div>
</fieldset>
</div>

<!-- Sowmya: Action items -->
<div>
<!-- meeting-controls / transcription -->
<fieldset id="meetingControlRecordingsSummary">
<legend>Recordings Summary</legend>
<div class="recordings summary">
<div class="btn-group u-mb">
<button id="gc-toggle-transcription" type="button"
onclick="toggleTranscription()" class="btn-code" data-enabled="false">Start Transcription</button>
</div>
<textarea id="gc-transcription-content"
disabled="">Content of transcriptions</textarea>
</div>
</fieldset>
</div>
Comment on lines +865 to +879
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix duplicate IDs and improve content.

Several issues need to be addressed:

  1. The button ID gc-toggle-transcription is duplicated from the previous fieldset
  2. The textarea ID gc-transcription-content is duplicated from the previous fieldset
  3. The textarea placeholder text could be more descriptive
  4. Developer comment should be removed

Apply this diff to fix the issues:

-        <!-- Sowmya: Action items -->
         <div>
           <!-- meeting-controls / transcription -->
           <fieldset id="meetingControlRecordingsSummary">
             <legend>Recordings Summary</legend>
             <div class="recordings summary">
               <div class="btn-group u-mb">
                 <button id="gc-toggle-recordings-transcription" type="button"
                   onclick="toggleTranscription()" class="btn-code" data-enabled="false">Start Transcription</button>
               </div>
               <textarea id="gc-recordings-transcription-content"
-                disabled="">Content of transcriptions</textarea>
+                disabled="">Recordings transcription content will appear here</textarea>
             </div>
           </fieldset>
         </div>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<!-- Sowmya: Action items -->
<div>
<!-- meeting-controls / transcription -->
<fieldset id="meetingControlRecordingsSummary">
<legend>Recordings Summary</legend>
<div class="recordings summary">
<div class="btn-group u-mb">
<button id="gc-toggle-transcription" type="button"
onclick="toggleTranscription()" class="btn-code" data-enabled="false">Start Transcription</button>
</div>
<textarea id="gc-transcription-content"
disabled="">Content of transcriptions</textarea>
</div>
</fieldset>
</div>
<div>
<!-- meeting-controls / transcription -->
<fieldset id="meetingControlRecordingsSummary">
<legend>Recordings Summary</legend>
<div class="recordings summary">
<div class="btn-group u-mb">
<button id="gc-toggle-recordings-transcription" type="button"
onclick="toggleTranscription()" class="btn-code" data-enabled="false">Start Transcription</button>
</div>
<textarea id="gc-recordings-transcription-content"
disabled="">Recordings transcription content will appear here</textarea>
</div>
</fieldset>
</div>


<div>
<!-- meeting-controls / tones -->
Expand Down
Loading