-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a semantic bundle configuration #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpdude
changed the title
Allow setting up shortcodes via config
Provide a semantic bundle configuration
May 27, 2022
mpdude
force-pushed
the
shortcode-as-config
branch
from
May 27, 2022 16:04
3b6102c
to
9234a86
Compare
Removed "optional", as the `guide.xml` is always included. You can still chose not include the guide in your routing, but that's a little bit too short for me to call it "optional".
MalteWunsch
reviewed
May 30, 2022
Thank you for the exhaustive review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having to set up service configuration like this:
... and using the
Webfactory\ShortcodeBundle\Handler\EmbeddedShortcodeHandler.inline
orWebfactory\ShortcodeBundle\Handler\EmbeddedShortcodeHandler.esi
parent services, with this PR you can instead write:The first is a shorthand notation to register the
my-shortcode
shortcode which will be rendered with theinline
strategy. The second is a bit more elaborate, but allows to specifyesi
as the rendering strategy.