Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setDoNotTrack
configuration value has to be pushed to the_paq
s before thetrackPageView
setting.trackPageView
seems to trigger the actual logging request when it is being processed.With the old state of the code,
setDoNotTrack
was set too late and never became effective. A request to the Matomo server would be sent in any case, relying on the server-side "do not track" privacy feature to be enabled.This change adds a new
enable_do_not_track
configuration setting which defaults totrue
.When you set it to
false
, thesetDoNotTrack
command will not be used. You can push it to the_paq
array yourself, possibly depending on client-side logic. But remember: It has to be in the_paq
array before thetrackPageView
entry.