Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advised usage for docker integration #11

Closed
bendavies opened this issue Nov 27, 2019 · 2 comments
Closed

Advised usage for docker integration #11

bendavies opened this issue Nov 27, 2019 · 2 comments

Comments

@bendavies
Copy link

bendavies commented Nov 27, 2019

Hey there!

Thanks for the great action.
Do you have any opinion on the best way to use this action with docker volumes?

I'm doing this but would like to know if there is a better way?

on: push

name: "Test"

jobs:
  build:
    name: "Test"

    runs-on: ubuntu-latest

    steps:

      - name: "Install SSH Key"
        uses: webfactory/ssh-agent@v0.1.1
        with:
          ssh-private-key: ${{ secrets.SSH_PRIVATE_KEY }}

      - name: "Test"
        run: |
          docker run --rm \
            -v $SSH_AUTH_SOCK:/ssh-agent -v ~/.ssh/known_hosts:/root/.ssh/known_hosts -e SSH_AUTH_SOCK=/ssh-agent \
            image \
            bash -c "ssh-add -l && ssh -T git@github.com"

Thanks!

@mpdude
Copy link
Member

mpdude commented Nov 27, 2019

Looks good to me and is the way I’d do it as well.

@bendavies
Copy link
Author

👍

ivan-hernandez-scopely added a commit to ivan-hernandez-scopely/unity-builder that referenced this issue Apr 26, 2021
ivan-hernandez-scopely added a commit to ivan-hernandez-scopely/unity-test-runner that referenced this issue Apr 26, 2021
dwalkes added a commit to dwalkes/ssh-agent that referenced this issue Jul 2, 2022
Fix link to issue webfactory#11 referenced in REAME
dwalkes added a commit to dwalkes/ssh-agent that referenced this issue Jul 2, 2022
Fix link to issue webfactory#11 referenced in REAME
cardoe added a commit to cardoe/ssh-agent that referenced this issue Mar 2, 2023
…types/node-18.14.0

Bump @types/node from 18.13.0 to 18.14.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants