-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot find git
executable on on windows-2022
(GitHub-hosted runner)
#136
Comments
mpdude
pushed a commit
that referenced
this issue
Oct 19, 2022
…tHub-hosted runner) (#137) ### Problem: Observed error on `windows-2022` ([GitHub-hosted runner](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources)) that `git` command cannot be found. ### Issue: Cannot find git executable on on windows-2022 (GitHub-hosted runner) #136 ### Solution: This path improvement makes use of existing `path.js` to resolve and return correct `git.exe` path for Windows, leaving the executable name as it was for other operating systems. ### Caveats: No idea how and why this `c://progra~1//git//usr//bin//git.exe` mumbo-jumbo works but it apparently did for other executables so figured it should work for `git.exe` (and it does).
mpdude
added a commit
that referenced
this issue
Oct 19, 2022
This PR fixes an apparently wrong path to the `git` binary that was added in #136. According to actions/checkout#928 (comment), the path should not contain the `usr/` part, although for `ssh-add` and `ssh-agent`, it has to.
@mpdude We could consider using something like that:
My js skills are too rusty to attempt it 🛑 |
Released v0.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Observed error on
windows-2022
(GitHub-hosted runner) thatgit
command cannot be found:Config:
Result:
The text was updated successfully, but these errors were encountered: