Skip to content
This repository has been archived by the owner on Jan 6, 2024. It is now read-only.

feat: show route meta info in pages tab #178

Merged
merged 6 commits into from
Aug 2, 2023

Conversation

xxholly32
Copy link
Contributor

#175

Since meta is an object, the data is displayed tiled, and the content is likely to be too long, so a title is added

with no data

image

with full data

image

and title:

image

@webfansplz webfansplz changed the title Route page add nickname feat: show route meta info in pages tab Jul 31, 2023
@webfansplz
Copy link
Owner

We can show it more clearly with json-editor. Show the basic info in the table and provide a tooltip with detailed json info when users hover over it.

You can check how json-editor works by looking at this file 👉 (https://github.com/webfansplz/vite-plugin-vue-devtools/blob/main/packages/client/pages/component-docs.vue#L75)

@xxholly32
Copy link
Contributor Author

json-editor has been added, please check it under review ❤

@webfansplz
Copy link
Owner

json-editor has been added, please check it under review ❤

LGTM. Thanks for your contribution ❤.

@webfansplz webfansplz merged commit 6fdfca3 into webfansplz:main Aug 2, 2023
1 check passed
@xxholly32
Copy link
Contributor Author

xxholly32 commented Aug 2, 2023

One small detail, since route meta data is displayed by default, the screenshots in the readme may need to be adjusted. 🤣🤣🤣

@webfansplz
Copy link
Owner

One small detail, since route meta data is displayed by default, the screenshots in the readme may need to be adjusted. 🤣🤣🤣

Sure. I'll update the readme later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants